Support Debian Buster (#34)

* README update
* Remove useless legacy files
* Small refactoring for Galera Cluster
* Modern Ansible
* Some changes on travis + Vagrant
* Help debug: display all facts
* Fix galera config for docker

.travis.yml

@@ -1,18 +1,27 @@
 env:
-  - PLATFORM='docker-stretch-default-mariadb-master'   ANSIBLE_VERSION='ansible>=2.3,<2.4'
+  - PLATFORM='docker-stretch-default-master'    ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-stretch-upstream-mariadb-master'  ANSIBLE_VERSION='ansible>=2.3,<2.4'
+  - PLATFORM='docker-stretch-upstream-master'   ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-stretch-upstream-mariadbgalera-1' ANSIBLE_VERSION='ansible>=2.3,<2.4'
+  - PLATFORM='docker-stretch-default-galera-1'  ANSIBLE_VERSION='ansible>=2.6,<2.7'
-
+  - PLATFORM='docker-stretch-upstream-galera-1' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-matrix:
+  - PLATFORM='docker-buster-default-master'     ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  allow_failures:
+  - PLATFORM='docker-buster-upstream-master'    ANSIBLE_VERSION='ansible>=2.6,<2.7'
-    - env: PLATFORM='docker-stretch-upstream-mariadbgalera-1' ANSIBLE_VERSION='ansible>=2.3,<2.4'
+  - PLATFORM='docker-buster-default-galera-1'   ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  fast_finish: true
+  - PLATFORM='docker-buster-upstream-galera-1'  ANSIBLE_VERSION='ansible>=2.6,<2.7'
+  - PLATFORM='docker-stretch-default-master'    ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-stretch-upstream-master'   ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-stretch-default-galera-1'  ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-stretch-upstream-galera-1' ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-buster-default-master'     ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-buster-upstream-master'    ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-buster-default-galera-1'   ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  - PLATFORM='docker-buster-upstream-galera-1'  ANSIBLE_VERSION='ansible>=2.7,<2.8'
 
 sudo: required
 
 dist: trusty
 
 language: python
+python: 2.7
 
 services:
   - docker
@@ -20,7 +29,7 @@ services:
 before_install:
   - wget https://releases.hashicorp.com/vagrant/2.0.1/vagrant_2.0.1_x86_64.deb
   - sudo dpkg -i vagrant_2.0.1_x86_64.deb
-  - vagrant plugin install vagrant-hostmanager 
+  - vagrant plugin install vagrant-hostmanager
 
 install:
   - pip install "$ANSIBLE_VERSION"

README.md

@@ -5,11 +5,12 @@ MariaDB (MySQL) Ansible role for Debian
 
 Install and configure MariaDB (Galera Cluster). Manage replication (master/slave). Create users and databases.
 
-| OS              | Vendor                  | Origin    | Managed versions          |
+| OS              | Origin    | MariaDB versions          |
-| --------------- | ----------------------- | --------- | ------------------------- |
+| --------------- | --------- | ------------------------- |
-| Debian Stretch  | MariaDB                 | Debian    | 10.1                      |
+| Debian Stretch  | Debian    | 10.1                      |
-| Debian Stretch  | MariaDB                 | Upstream  | 10.1 / 10.2 / 10.3        |
+| Debian Stretch  | Upstream  | 10.1 / 10.2 / 10.3 / 10.4 |
-| Debian Stretch  | MariaDB Galera Cluster  | Upstream  | 10.1 / 10.2               |
+| Debian Buster   | Debian    | 10.3                      |
+| Debian Buster   | Upstream  | 10.3 / 10.4               |
 
 Notes
 -----
@@ -17,17 +18,17 @@ Notes
 * Galera Cluster is experimental
 * Due to Vagrant + Docker limitation (private network), replication/galera can't be checked with Travis
 * If you need to test this role with Vagrant, you must install hostmanager plugin: `vagrant plugin install vagrant-hostmanager`
+* Percona Xtrabackup is not available in upstream repository. This feature is disabled in the role.
 
 Requirements
 ------------
 
-None.
+Ansible 2.5+
 
 Role Variables
 --------------
 
-- `mariadb_origin`: origin of the package ("default" or "upstream")
+- `mariadb_use_galera`: set true to configure and install Galera Cluster
-- `mariadb_vendor`: "mariadb", "mariadb\_galera"
 
 ### Configuration
 
@@ -47,17 +48,21 @@ Example:
 
 ```
 mariadb_users:
-  - name: 'kiki'
+  - name: 'lorem'
     password: '123'
-    priv: hihi.*:ALL
+    priv: lorem.*:ALL
-    host: '%'
+    host: 'localhost'
+  - name: 'ipsum'
+    password: '465'
+    priv: ipsum.*:ALL
+    host_all: yes
 ```
 
 Check "priv" syntax in [mysql\_user module documentation](http://docs.ansible.com/mysql_user_module.html)
 
 ### Packaging
 
-- `mariadb_version`: 10.0 / 10.1 / 10.2
+- `mariadb_version`: depends Debian version
 - `mariadb_repository`: MariaDB upstream APT repository (see: [MariaDB repositories tool](https://downloads.mariadb.org/mariadb/repositories))
 - `mariadb_percona_repository`: Percona upstream APT repository (see: [Percona APT doc](http://www.percona.com/doc/percona-server/5.5/installation/apt_repo.html))
 - `mariadb_use_percona_apt`: Force using Percona APT repository (useful when you want to use latest version of percona toolkits, xtrabackup... etc)
@@ -72,7 +77,7 @@ Example Playbook
 
     - hosts: servers
       roles:
-         - { role: HanXHX.mysql, mariadb_origin: 'upstream', mariadb_vendor: 'mariadb' }
+         - { role: HanXHX.mysql, mariadb_origin: 'upstream' }
 
 License
 -------

Vagrantfile

@@ -7,6 +7,8 @@ Vagrant.configure("2") do |config|
 
   vbox_deb_stretch = 'debian/stretch64'
   dk_deb_stretch = 'hanxhx/vagrant-ansible:debian9'
+  vbox_deb_buster = 'debian/buster64'
+  dk_deb_buster = 'hanxhx/vagrant-ansible:debian10'
 
   config.hostmanager.enabled = true
   config.hostmanager.manage_host = false
@@ -15,14 +17,49 @@ Vagrant.configure("2") do |config|
   config.hostmanager.include_offline = false
 
   cases = [
+    # ========================
     # Debian Stretch
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'default',  mariadb_vendor: 'mariadb' }, groups: ['master'] },
+    # ========================
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'default',  mariadb_vendor: 'mariadb' }, groups: ['slave'] },
+
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'upstream', mariadb_vendor: 'mariadb' }, groups: ['master'] },
+    # Default replication
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream', mariadb_vendor: 'mariadb' }, groups: ['slave'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'default'  }, groups: ['master'] },
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'upstream' },                          groups: ['mariadbgalera', '1'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'default'  }, groups: ['slave'] },
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream' },                          groups: ['mariadbgalera', '2'] },
+
-    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream' },                          groups: ['mariadbgalera', '3'] },
+    # Upstream replication
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'upstream' }, groups: ['master'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream' }, groups: ['slave'] },
+
+    # Galera Debian
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'default'  }, groups: ['galera', '1'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'default'  }, groups: ['galera', '2'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'default'  }, groups: ['galera', '3'] },
+
+    # Galera Upstream
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: dk_deb_stretch, vars: {mariadb_origin: 'upstream' }, groups: ['galera', '1'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream' }, groups: ['galera', '2'] },
+    { os_name: 'stretch', vbox: vbox_deb_stretch, docker: nil,            vars: {mariadb_origin: 'upstream' }, groups: ['galera', '3'] },
+
+    # ========================
+    # Debian Buster
+    # ========================
+
+    # Default replication
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: dk_deb_buster, vars: {mariadb_origin: 'default'  }, groups: ['master'] },
+#   { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'default'  }, groups: ['slave'] },
+
+    # Upstream replication
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: dk_deb_buster, vars: {mariadb_origin: 'upstream' }, groups: ['master'] },
+#   { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'upstream' }, groups: ['slave'] },
+
+    # Galera Debian
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: dk_deb_buster, vars: {mariadb_origin: 'default'  }, groups: ['galera', '1'] },
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'default'  }, groups: ['galera', '2'] },
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'default'  }, groups: ['galera', '3'] },
+
+    # Galera Upstream
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: dk_deb_buster, vars: {mariadb_origin: 'upstream' }, groups: ['galera', '1'] },
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'upstream' }, groups: ['galera', '2'] },
+    { os_name: 'buster', vbox: vbox_deb_buster, docker: nil,           vars: {mariadb_origin: 'upstream' }, groups: ['galera', '3'] },
   ]
 
   cases.each_with_index do |opts,index|

defaults/main.yml

@@ -4,7 +4,7 @@
 # Setup
 # -------------------------------------
 mariadb_origin: 'default'
-mariadb_vendor: 'mariadb'
+mariadb_use_galera: false
 mariadb_root_password: 'change_me_NOW'
 mariadb_notify_restart: true
 mariadb_upstream_apt_src: false
@@ -124,7 +124,7 @@ mariadb_users: []
 # -------------------------------------
 # MariaDB
 # -------------------------------------
-mariadb_version: '10.1'
+mariadb_version: '10.3'
 mariadb_mirror_domain: "ftp.igh.cnrs.fr"
 # See: https://downloads.mariadb.org/mariadb/repositories
 mariadb_repository: "http://{{ mariadb_mirror_domain }}/pub/mariadb/repo/{{ mariadb_version }}/debian"
@@ -135,11 +135,13 @@ mariadb_key_ids: ['0xcbcb082a1bb943db', '0xf1656f24c74cd1d8']
 # Galera
 # -------------------------------------
 mariadb_galera_resetup: false
+mariadb_wsrep_node_address: false # Set primary node IP 
 mariadb_galera_members: []
 mariadb_galera_primary_node: 'change_me' # See: https://github.com/ansible/ansible/issues/17453
+mariadb_wsrep_stt_method: 'rsync'
 
 # -------------------------------------
-# Percona 
+# Percona
 # -------------------------------------
 mariadb_percona_repository: 'http://repo.percona.com/apt'
 mariadb_use_percona_apt: false

meta/main.yml

@@ -4,14 +4,14 @@ galaxy_info:
   description: Install and configure MariaDB (and Galera Cluster) on Debian 
   company: 
   license: GPLv2
-  min_ansible_version: 2.3
+  min_ansible_version: 2.5
   platforms:
   - name: Debian
     versions:
     - stretch
+    - buster
   galaxy_tags:
   - database
-  - database:sql
   - packaging
   - mysql
   - mariadb

tasks/galera/bootstrap.yml

@@ -1,9 +1,11 @@
 ---
-- set_fact:
+- name: SET_FACT | Prepare mark var
-    booboo: "{{ mariadb_datadir }}/.ansible_galera_boostrap"
+  set_fact:
+    __mark: "{{ mariadb_datadir }}/.ansible_galera_boostrap"
 
 - name: STAT | Bootstrap mark
-  stat: path={{ booboo }}
+  stat:
+    path: "{{ __mark }}"
   register: s
 
 - block:
@@ -12,7 +14,9 @@
         mariadb_notify_restart: false
 
     - name: SERVICE | Stop MariaDB
-      service: name=mysql state=stopped
+      service:
+        name: mysql
+        state: stopped
 
     - name: COMMAND | Bootstrap first node (systemd)
       command: galera_new_cluster
@@ -29,6 +33,6 @@
   when: not s.stat.exists or mariadb_galera_resetup
 
 - name: COMMAND | Create Bootstrap mark
-  command: "touch {{ booboo }}"
+  command: "touch {{ __mark }}"
   args:
-    creates: "{{ booboo }}"
+    creates: "{{ __mark }}"

tasks/galera/main.yml

@@ -7,18 +7,18 @@
   register: galeraconfig
 
 - name: INCLUDE | Bootstrap first node
-  include: 'bootstrap.yml'
+  import_tasks: 'bootstrap.yml'
   when: inventory_hostname == mariadb_galera_primary_node
 
 - name: INCLUDE | Configure other nodes
-  include: 'nodes.yml'
+  import_tasks: 'nodes.yml'
   when: inventory_hostname != mariadb_galera_primary_node
 
 - name: SERVICE | Restart MariaDB if needed
   service:
     name: mysql
     state: restarted
-  when: >
+  when:
     ((galeraconfig or (p is defined and p.changed)) and
     (bootstrap_run is not defined)) or
     ((inventory_hostname != mariadb_galera_primary_node) and

tasks/install/main.yml

@@ -1,24 +1,22 @@
 ---
 
-- name: INCLUDE | Use Percona repository
+- name: INCLUDE | Setup Percona repository
-  include: 'percona/apt.yml'
+  import_tasks: 'percona/apt.yml'
-  when: mariadb_use_percona_apt
+  when: mariadb_use_percona_apt | bool
 
-- name: INCLUDE | Install MariaDB from Debian repo
+- name: INCLUDE | Setup MariaDB repository
-  include: 'mariadb/default.yml'
+  import_tasks: 'mariadb/upstream.yml'
-  when: mariadb_origin == 'default' and mariadb_vendor == 'mariadb'
-
-- name: INCLUDE | Install MariaDB from MariaDB repo
-  include: 'mariadb/upstream.yml'
   when: mariadb_origin == 'upstream'
 
+- name: INCLUDE | Install MariaDB
+  import_tasks: 'mariadb/default.yml'
+
 - name: APT | Install few MariaDB related tools
   apt:
-    pkg: "{{ item }}"
+    pkg: "{{ mariadb_tools }}"
     install_recommends: no
-  with_items: "{{ mariadb_tools }}"
 
 - name: APT | Install percona-xtrabackup if needed
   apt:
     pkg: "{{ mariadb_xtrabackup_package }}"
-  when: mariadb_install_xtrabackup_package
+  when: mariadb_install_xtrabackup_package | bool

tasks/install/mariadb/default.yml

@@ -28,4 +28,4 @@
 - name: APT | Install Galera
   apt:
     pkg: galera-3
-  when: mariadb_vendor == 'mariadb_galera'
+  when: mariadb_use_galera

tasks/install/mariadb/upstream.yml

@@ -4,7 +4,7 @@
   apt_key:
     keyserver: "{{ mariadb_key_server }}"
     id: "{{ item }}"
-  with_items: "{{ mariadb_key_ids }}"
+  loop: "{{ mariadb_key_ids }}"
 
 - name: TEMPLATE | Deploy APT pinning (prevent upgrades from Debian)
   template:
@@ -19,6 +19,3 @@
   apt_repository:
     repo: 'deb-src {{ mariadb_repository }} {{ ansible_distribution_release }} main'
   when: mariadb_upstream_apt_src
-
-- name: INCLUDE | Normal Install
-  include: default.yml

tasks/install/percona/apt.yml

@@ -1,20 +1,16 @@
 ---
 
-- name: APT_KEY | Install Percona key
+- name: APT | Install Percona repository
-  apt_key:
+  apt:
-    keyserver: "keyserver.ubuntu.com"
+    deb: https://repo.percona.com/apt/percona-release_latest.generic_all.deb
-    id: "8507EFA5"
 
-- name: TEMPLATE | Deploy APT pinning (prevent upgrades from Debian)
+- name: COMMAND | Enable percona tools repository
-  template:
+  command: percona-release enable tools release
-    src: etc/apt/preferences.d/95-percona.j2
+  args:
-    dest: /etc/apt/preferences.d/95-percona
+    creates: /etc/apt/sources.list.d/percona-tools-release.list
+  register: p
 
-- name: APT_REPOSITORY | Add Percona repository
+- name: APT | Update cache
-  apt_repository:
+  apt:
-    repo: 'deb {{ mariadb_percona_repository }} {{ ansible_distribution_release }} main'
+    update_cache: yes
-
+  when: p.changed
-- name: APT_RESPOSITORY | Add Percona (src) repository
-  apt_repository:
-    repo: 'deb-src {{ mariadb_percona_repository }} {{ ansible_distribution_release }} main'
-  when: mariadb_upstream_apt_src

tasks/main.yml

@@ -1,5 +1,13 @@
 ---
 
+- block:
+
+    - name: SET_FACT | Bypass https://github.com/ansible/ansible/issues/19874
+      set_fact:
+        ansible_distribution_release: 'buster'
+
+  when: ansible_facts.distribution_major_version == "buster/sid"
+
 - name: INCLUDE_VARS | Related to OS version
   include_vars: "{{ ansible_distribution }}-{{ ansible_distribution_release }}.yml"
 
@@ -10,7 +18,7 @@
   changed_when: false
 
 - name: INCLUDE | Install
-  include: install/main.yml
+  import_tasks: install/main.yml
 
 - name: TEMPLATE | Deploy configuration
   template:
@@ -28,7 +36,7 @@
   service:
     name: mysql
     state: restarted
-  when: >
+  when:
     (config.changed or extraconfig.changed) and
     not mariadb_galera_resetup
 
@@ -42,15 +50,15 @@
     backup: yes
 
 - name: INCLUDE | Galera
-  include: galera/main.yml
+  import_tasks: galera/main.yml
-  when: mariadb_vendor == 'mariadb_galera'
+  when: mariadb_use_galera
 
 - name: INCLUDE | Replication
-  include: replication/main.yml
+  import_tasks: replication/main.yml
   when: mariadb_replication_master or mariadb_replication_slave
 
 - name: INCLUDE | Secure install
-  include: 'secure.yml'
+  import_tasks: 'secure.yml'
 
 - name: SERVICE | Ensure service is started
   service:
@@ -61,19 +69,20 @@
   mysql_db:
     name: "{{ item }}"
     state: present
-  with_items: "{{ mariadb_databases }}"
+  loop: "{{ mariadb_databases }}"
 
 - name: MYSQL_USER | Manages users...
   mysql_user:
     name: "{{ item.name }}"
     password: "{{ item.password }}"
     priv: "{{ item.priv }}"
-    host: "{{ item.host | default('localhost') }}"
+    host: "{{ item.host | default(omit) }}"
+    host_all: "{{ item.host_all | default(omit) }}"
     state: present
-  with_items: "{{ mariadb_users }}"
+  loop: "{{ mariadb_users }}"
 
 - name: TEMPLATE | Deploy logrotate configuration
   template:
     src: "etc/logrotate.d/mysql-server.j2"
     dest: "/etc/logrotate.d/mysql-server"
-  when: mariadb_manage_logrotate
+  when: mariadb_manage_logrotate | bool

tasks/replication/main.yml

@@ -1,9 +1,9 @@
 ---
 
 - name: INCLUDE | Replication Master
-  include: master.yml
+  import_tasks: master.yml
   when: mariadb_replication_master
 
 - name: INCLUDE | Replication slave
-  include: slave.yml
+  import_tasks: slave.yml
   when: mariadb_replication_slave

tasks/replication/slave.yml

@@ -19,19 +19,19 @@
   register: slave_status
 
 - name: INCLUDE | Transfert /etc/mysql/debian.cnf from master
-  include: slave/ssh.yml
+  import_tasks: slave/ssh.yml
   when: mariadb_slave_replicate_mysqldb or ((slave_status.failed is defined or not slave_status.Is_Slave) and mariadb_slave_import_data)
 
 - name: INCLUDE | Import data
-  include: slave/import_data.yml
+  import_tasks: slave/import_data.yml
   when: (slave_status.failed is defined or not slave_status.Is_Slave) and mariadb_slave_import_data
 
 - name: INCLUDE | Configure replication
-  include: slave/replication.yml
+  import_tasks: slave/replication.yml
   when: (slave_status.failed is defined or not slave_status.Is_Slave) or mariadb_slave_force_setup
 
 - name: INCLUDE | Transfert /etc/mysql/debian.cnf from master
-  include: slave/debiancnf.yml
+  import_tasks: slave/debiancnf.yml
   when: mariadb_slave_replicate_mysqldb
 
 - name: MYSQL_REPLICATION | Get slave status
@@ -41,4 +41,4 @@
   register: slave_status
 
 - name: Configure GTID
-  include: slave/gtid.yml
+  import_tasks: slave/gtid.yml

tasks/replication/slave/debiancnf.yml

@@ -9,7 +9,10 @@
   delegate_to: "{{ mariadb_slave_import_from }}"
 
 - name: LOCAL_ACTION FILE | Secure fetched file
-  local_action: file path=/tmp/{{ mariadb_slave_import_from }}/debian.cnf mode=0600
+  local_action:
+    module: file
+    path: "/tmp/{{ mariadb_slave_import_from }}/debian.cnf"
+    mode: 0600
   become: no
 
 - name: COPY | Fetched file to /etc/mysql/debian.cnf

tasks/replication/slave/import_data.yml

@@ -7,7 +7,9 @@
     port: 22
 
 - name: COMMAND | Prepare backup another server
-  command: innobackupex --no-timestamp {{ mariadb_backup_dir }} creates={{ mariadb_backup_dir }}
+  command: innobackupex --no-timestamp {{ mariadb_backup_dir }}
+  args:
+    creates: "{{ mariadb_backup_dir }}"
   delegate_to: "{{ mariadb_slave_import_from }}"
   register: backup
 
@@ -24,7 +26,8 @@
   when: backup.changed and not mariadb_slave_replicate_mysqldb
 
 - name: MYSQL_VARIABLES | Get datadir
-  mysql_variables: variable=datadir
+  mysql_variables:
+    variable: datadir
   register: datadir
 
 - name: SET_FACT | related to mysql datadir
@@ -74,6 +77,8 @@
     mariadb_master_gtid: "{{ master_gtid.stdout }}"
 
 - name: FILE | Delete dump
-  file: path={{ mariadb_backup_dir }} state=absent
+  file:
+    path: "{{ mariadb_backup_dir }}"
+    state: absent
   delegate_to: "{{ mariadb_slave_import_from }}"
   when: mariadb_slave_import_flush_dump

tasks/secure.yml

@@ -5,7 +5,7 @@
     name: root
     host: "{{ item }}"
     password: "{{ mariadb_root_password }}"
-  with_items:
+  loop:
     - "{{ ansible_hostname }}"
     - 127.0.0.1
     - ::1
@@ -16,7 +16,7 @@
     name: ''
     host: "{{ item }}"
     state: absent
-  with_items:
+  loop:
     - "{{ ansible_hostname }}"
     - 127.0.0.1
     - ::1

templates/etc/mysql/conf.d/09-galera.cnf.j2

@@ -12,12 +12,13 @@
 wsrep_on=ON
 wsrep_provider=/usr/lib/galera/libgalera_smm.so
 wsrep_cluster_address=gcomm://{{ mariadb_galera_members | join(",") }}
-# TODO: https://mariadb.com/kb/en/mariadb/galera-cluster-system-variables/#wsrep_sst_method
+wsrep_sst_method="{{ mariadb_wsrep_stt_method }}"
-wsrep_sst_method=rsync
+{% if mariadb_wsrep_cluster_name is defined %}
-# TODO: wsrep_cluster_name="my_wsrep_cluster"
+wsrep_cluster_name="{{ mariadb_wsrep_cluster_name }}"
+{% endif %}
 
 # Node Configuration
-wsrep_node_address="{{ mariadb_wsrep_node_address | default(ansible_default_ipv4.address) }}"
+wsrep_node_address="{{ mariadb_wsrep_node_address | default(ansible_default_ipv4.address if ansible_default_ipv4 is defined else '127.0.0.1') }}"
 wsrep_node_name="{{ mariadb_wsrep_node_name | default(ansible_fqdn) }}"
 
 
@@ -28,4 +29,6 @@ binlog_format=ROW
 default_storage_engine=InnoDB
 innodb_autoinc_lock_mode=2
 innodb_doublewrite=1
+{% if mariadb_version == '10.0'%}
 query_cache_size=0
+{% endif %}

tests/group_vars/galera

@@ -1,5 +1,5 @@
-mariadb_vendor: 'mariadb_galera'
+mariadb_use_galera: true
 mariadb_galera_members:
-  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-mariadbgalera-1'
+  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-galera-1'
-  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-mariadbgalera-2'
+  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-galera-2'
-  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-mariadbgalera-3'
+  - '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-galera-3'

tests/group_vars/mysql

@@ -1 +0,0 @@
-mariadb_vendor: 'mysql'

tests/test.yml

@@ -1,22 +1,38 @@
 ---
 
 - hosts: all
+  gather_facts: false
+  pre_tasks:
+    - name: SETUP | Get facts
+      setup:
+      register: s
+    - name: DEBUG | Show facts
+      debug:
+        var: s
   tasks:
-    - apt: pkg={{ item }} state=present update_cache=yes cache_valid_time=3600
+    - name: APT | Install some packages
-      with_items:
+      apt:
-        - ca-certificates
+        name: "{{ p }}"
-        - curl
+        update_cache: yes
-        - strace
+        cache_valid_time: 3600
-        - vim
+      vars:
+        p: ['ca-certificates', 'curl', 'strace', 'vim']
 
 - hosts: master
   roles:
     - ../../
   tasks:
-    - copy: src=import1.sql dest=/tmp/import1.sql
+    - name: COPY | Deploy first dump
+      copy:
+        src: import1.sql
+        dest: /tmp/import1.sql
       register: c
-    - mysql_db: name={{ item }} state=import target=/tmp/import1.sql
+    - name: MYSQL_DB | Import first dump
-      with_items: ['testrepl', 'norepl']
+      mysql_db:
+        name: "{{ item }}"
+        state: import
+        target: /tmp/import1.sql
+      loop: ['testrepl', 'norepl']
       when: c.changed
 
 - hosts: slave
@@ -25,7 +41,8 @@
       shell: getent hosts {{ ansible_hostname | replace ('slave', 'master') }} | cut -d ' ' -f 1
       register: ip
       changed_when: false
-    - set_fact:
+    - name: SET_FACT | Apply some configuration
+      set_fact:
         # MariaDB don't read /etc/hosts (from vagrant host plugin)
         mariadb_replication_host: "{{ ip.stdout }}"
         # Need this to use vagrant 'delegate_to'
@@ -33,27 +50,39 @@
   roles:
     - ../../
   tasks:
-    - copy: src=import2.sql dest=/tmp/import2.sql
+    - name: COPY | Deploy dump
+      copy:
+        src: import2.sql
+        dest: /tmp/import2.sql
       delegate_to: "{{ mariadb_slave_import_from }}"
       register: c
-    - mysql_db: name={{ item }} state=import target=/tmp/import2.sql
+    - name: MYSQL_DB | Import another dump
-      with_items: ['testrepl', 'norepl']
+      mysql_db:
+        name: "{{ item }}"
+        state: import
+        target: /tmp/import2.sql
+      loop: ['testrepl', 'norepl']
       delegate_to: "{{ mariadb_slave_import_from }}"
       when: c.changed
-    - mysql_replication: mode=getslave
+    - name: MYSQL_REPLICATION | Get slave infos
+      mysql_replication:
+        mode: getslave
       register: slave
-    - fail: msg="Slave issue"
+    - name: FAIL | if slave threads are not running
+      fail:
+        msg: "Slave issue"
       when: slave.Slave_IO_Running != 'Yes' or slave.Slave_SQL_Running != 'Yes'
 
-- hosts: mariadbgalera
+- hosts: galera
-  vars:
-    mariadb_galera_primary_node: '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-upstream-mariadbgalera-1'
-    mariadb_wsrep_node_address: "{{ ansible_all_ipv4_addresses[0] }}"
-    mariadb_version: '10.1'
   pre_tasks:
-    - set_fact:
+    - name: SET_FACT | Bypass https://github.com/ansible/ansible/issues/19874
-        mariadb_wsrep_node_address: "{{ ansible_eth1.ipv4.address }}"
+      set_fact:
-      when: not is_docker
+        ansible_distribution_release: 'buster'
+      when: ansible_facts.distribution_major_version == "buster/sid"
+    - name: SET_FACT | Apply some configuration
+      set_fact:
+        mariadb_galera_primary_node: '{% if is_docker %}docker-{% else %}vbox-{% endif %}{{ ansible_distribution_release }}-{{ mariadb_origin }}-galera-1'
+        mariadb_wsrep_node_address: "{{ '127.0.0.1' if is_docker else ansible_eth1.ipv4.address }}"
+        mariadb_version: '10.3'
   roles:
     - ../../
-

tests/travis.sh

@@ -1,21 +0,0 @@
-#!/bin/sh
-
-# Thanks to https://servercheck.in/blog/testing-ansible-roles-travis-ci-github
-
-DIR=$( dirname $0 )
-INVENTORY_FILE="localhost,"
-PLAYBOOK="$DIR/travis.yml"
-
-set -ev
-
-# Check syntax
-ansible-playbook -i $INVENTORY_FILE -c local --syntax-check -vv $PLAYBOOK
-
-# Check role
-ansible-playbook -i $INVENTORY_FILE -c local -e "{ mariadb_vendor: $VENDOR, mariadb_origin: $ORIGIN }" --sudo -vv $PLAYBOOK
-
-# Check indempotence
-ansible-playbook -i $INVENTORY_FILE -c local -e "{ mariadb_vendor: $VENDOR, mariadb_origin: $ORIGIN }" --sudo -vv $PLAYBOOK > idempot.txt
-grep -q 'changed=0.*failed=0' idempot.txt \
-&& (echo 'Idempotence test: pass' && exit 0) \
-|| (echo 'Idempotence test: FAIL' && cat idempot.txt && exit 1)

tests/travis.yml

@@ -1,15 +0,0 @@
----
-
-- hosts: all
-  vars:
-    mariadb_replication_master: true
-    mariadb_bind_address: '{{ ansible_eth0.ipv4.address }}'
-    mariadb_galera_members:
-      - '{{ ansible_eth0.ipv4.address }}'
-    mariadb_galera_primary_node: 'localhost'
-  roles:
-    - ../../
-  post_tasks:
-    - name: TEST | SHELL | Test mysql
-      shell: mysql -e "SHOW DATABASES;"
-      changed_when: false

vars/Debian-buster.yml

@@ -0,0 +1,6 @@
+mariadb_tools:
+  - percona-toolkit
+  - python-mysqldb
+  - mysqltuner
+
+mariadb_default_xtrabackup_package: 'percona-xtrabackup-24'