🚨 Fix linter

tasks/install/FreeBSD.yml

@@ -21,20 +21,17 @@
       ansible.builtin.command: touch /usr/local/etc/fdfs/http.conf
       args:
         creates: /usr/local/etc/fdfs/http.conf
-      register: fd1
+      notify: Restart nginx
 
     - name: LINEINFILE | Tune fdfs
-      ansible.builtin.lineinansible.builtin.file:
+      ansible.builtin.lineinfile:
         regexp: ^load_fdfs_parameters_from_tracker
         line: load_fdfs_parameters_from_tracker=false
         path: /usr/local/etc/fdfs/mod_fastdfs.conf
-      register: fd2
+      notify: Restart nginx
 
-    - name: SERVICE | Restart nginx when fdfs is tuned
-      ansible.builtin.service:
-        name: nginx
-        state: restarted
-      when: fd1.changed or fd2.changed
+    - name: META | Flush handlers (Restart nginx when fdfs is tuned)
+      ansible.builtin.meta: flush_handlers
 
 - name: FILE | Create configuration dir (like Debian)
   ansible.builtin.file:

tasks/ssl/acme.yml

@@ -29,25 +29,27 @@
         group: root
       loop: "{{ acme_create }}"
       register: fake_site
+      notify: Restart nginx
 
-    - name: FILE | Delete current site if needed
+    - name: TEMPLATE | Create fake site
+      ansible.builtin.template:
+        src: "etc/nginx/conf.d/FAKESITE.conf.j2"
+        dest: "/tmp/FAKESITE_{{ item | nginx_site_name }}.conf"
+        mode: 0644
+        owner: root
+        group: root
+      loop: "{{ acme_create }}"
+
+    - name: FILE | Delete current site if needed  # noqa: no-handler
       ansible.builtin.file:
         path: "{{ nginx_etc_dir }}/sites-enabled/{{ item | nginx_site_name }}"
         state: absent
       loop: "{{ acme_create }}"
       when: fake_site.changed
+      notify: Restart nginx
 
-    - name: SERVICE | Restart nginx
-      ansible.builtin.service:
-        name: nginx
-        state: restarted
-      when: fake_site.changed and ansible_virtualization_type != 'docker'
-
-    - name: COMMAND | Restart nginx
-      ansible.builtin.command: service nginx restart
-      args:
-        warn: false
-      when: fake_site.changed and ansible_virtualization_type == 'docker'
+    - name: META | Ensure nginx is restarted if needed
+      ansible.builtin.meta: flush_handlers
 
     - name: COMMAND | Get certificates
       ansible.builtin.command: |

tasks/ssl/standard.yml

@@ -4,22 +4,26 @@
   when: nginx_dh is not string
   block:
 
-  - name: STAT | Get info about DH file
-    ansible.builtin.stat:
-      path: "{{ nginx_dh_path }}"
-      get_checksum: false
-    register: stat_dh_file
+    - name: STAT | Get info about DH file
+      ansible.builtin.stat:
+        path: "{{ nginx_dh_path }}"
+        get_checksum: false
+      register: stat_dh_file
 
-  - name: SHELL | Get info about DH file
-    ansible.builtin.shell: openssl dhparam -in {{ nginx_dh_path }} -text -noout 2>&1 | awk '/DH Parameters/ { print substr($3, 2) }'
-    changed_when: false
-    register: dh_info
-    when: stat_dh_file.stat.exists
+    - name: SHELL | Get info about DH file
+      ansible.builtin.shell: |
+        set -o pipefail &&
+        openssl dhparam -in {{ nginx_dh_path }} -text -noout 2>&1 | awk '/DH Parameters/ { print substr($3, 2) }'
+      args:
+        executable: /bin/bash
+      changed_when: false
+      register: dh_info
+      when: stat_dh_file.stat.exists
 
-  - name: COMMAND | Generate DH file
-    ansible.builtin.command: openssl dhparam -out {{ nginx_dh_path }} {{ nginx_dh_length }}
-    when: not stat_dh_file.stat.exists or (dh_info.stdout | int != nginx_dh_length | int)
-    notify: Restart nginx
+    - name: COMMAND | Generate DH file  # noqa: no-changed-when
+      ansible.builtin.command: openssl dhparam -out {{ nginx_dh_path }} {{ nginx_dh_length }}
+      when: not stat_dh_file.stat.exists or (dh_info.stdout | int != nginx_dh_length | int)
+      notify: Restart nginx
 
 - name: COPY | Deploy DH file from vars
   ansible.builtin.copy: