Drop debian stretch support

Fix some handlers
Fix again...
2026-02-28 09:42:09 +07:00 · 2022-10-06 14:38:21 +02:00 · 2022-10-06 14:28:40 +02:00 · 2022-10-06 12:52:19 +02:00 · 2022-10-06 12:42:56 +02:00 · 2022-10-06 12:14:55 +02:00
24 changed files with 345 additions and 235 deletions
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -0,0 +1,8 @@
+---
+
+# TODO: enable later
+enable_list:
+  - fqcn-builtins
+
+skip_list:
+  - role-name
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,33 +1,36 @@
+---
+
 env:
-  - PLATFORM='docker-debian-stretch-php70' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-debian-buster-php73' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-ubuntu-xenial-php70' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-ubuntu-bionic-php72' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-ubuntu-bionic-php72' ANSIBLE_VERSION='ansible>=2.6,<2.7'
-  - PLATFORM='docker-debian-stretch-php70' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-debian-stretch-php74' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-debian-buster-php73' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-debian-buster-php74' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-ubuntu-xenial-php70' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-ubuntu-bionic-php72' ANSIBLE_VERSION='ansible>=2.7,<2.8'
-  - PLATFORM='docker-ubuntu-bionic-php72' ANSIBLE_VERSION='ansible>=2.7,<2.8'
+  global:
+    - VAGRANT_VERSION='2.2.18'
+  jobs:
+    - PLATFORM='docker-debian-buster-php73'   ANSIBLE_VERSION='>=2.11,<2.12'
+    - PLATFORM='docker-debian-bullseye-php74' ANSIBLE_VERSION='>=2.11,<2.12'
+    - PLATFORM='docker-debian-bullseye-php80' ANSIBLE_VERSION='>=2.11,<2.12'
+    - PLATFORM='docker-debian-buster-php74'   ANSIBLE_VERSION='>=2.11,<2.12'
+    - PLATFORM='docker-ubuntu-bionic-php72'   ANSIBLE_VERSION='>=2.11,<2.12'

-sudo: required
-
-dist: trusty
+os:
+  - linux
+dist: focal

 language: python
-python: 2.7
+python:
+  - 3.8

 services:
  - docker

 before_install:
-  - wget https://releases.hashicorp.com/vagrant/2.0.1/vagrant_2.0.1_x86_64.deb
-  - sudo dpkg -i vagrant_2.0.1_x86_64.deb
+  - sudo apt-get -q update
+  - sudo apt-get install -y yamllint
+  - sudo wget -nv https://releases.hashicorp.com/vagrant/${VAGRANT_VERSION}/vagrant_${VAGRANT_VERSION}_x86_64.deb
+  - sudo dpkg -i vagrant_${VAGRANT_VERSION}_x86_64.deb

 install:
-  - pip install "$ANSIBLE_VERSION"
+  - sudo pip install "ansible-core$ANSIBLE_VERSION"
+  - sudo pip install ansible-lint
+  - ansible-galaxy collection install community.general

 script:
  - VAGRANT_DEFAULT_PROVIDER=docker vagrant up $PLATFORM
@@ -37,6 +40,14 @@ script:
    && (echo 'Idempotence test: pass' && exit 0)
    || (echo 'Idempotence test: fail' && exit 1)
  - VAGRANT_DEFAULT_PROVIDER=docker vagrant status
+  - >
+    yamllint .
+    && (echo 'YAML lint test: pass' && exit 0)
+    || (echo 'YAML lint test: fail' && exit 1)
+  - >
+    ansible-lint -v tests/test.yml
+    && (echo 'Ansible lint test: pass' && exit 0)
+    || (echo 'Ansible lint test: fail' && exit 1)

 notifications:
  webhooks: https://galaxy.ansible.com/api/v1/notifications/
--- a/.yamllint.yml
+++ b/.yamllint.yml
@@ -0,0 +1,6 @@
+---
+
+extends: default
+
+rules:
+  line-length: disable
--- a/README.md
+++ b/README.md
@@ -1,21 +1,22 @@
 Ansible PHP (+FPM) role for Debian / Ubuntu / FreeBSD
 =====================================================

-[![Ansible Galaxy](http://img.shields.io/badge/ansible--galaxy-HanXHX.php-blue.svg)](https://galaxy.ansible.com/HanXHX/php) [![Build Status](https://travis-ci.org/HanXHX/ansible-php.svg?branch=master)](https://travis-ci.org/HanXHX/ansible-php)
+[![Ansible Galaxy](http://img.shields.io/badge/ansible--galaxy-hanxhx.php-blue.svg)](https://galaxy.ansible.com/hanxhx.php) [![Build Status](https://app.travis-ci.com/HanXHX/ansible-php.svg?branch=master)](https://app.travis-ci.com/HanXHX/ansible-php)

 Install PHP on Debian / Ubuntu / FreeBSD. Manage PHP-FPM, APCu, Opcache and Xdebug.

 Managed OS / Versions
 ---------------------

-|         OS            |       PHP 7.0       |          PHP 7.1           |          PHP 7.2           |           PHP 7.3         |           PHP 7.4         |
-|:---------------------:|:-------------------:|:--------------------------:|:--------------------------:|:-------------------------:|:--------------------------:
-| Debian Stretch (9)    | :heavy_check_mark:  | :heavy_check_mark: (Sury)  | :heavy_check_mark: (Sury)  | :heavy_check_mark: (Sury) | :heavy_check_mark: (Sury) |
-| Debian Buster (10)    | :x:                 | :x:                        | :x:                        | :heavy_check_mark:        | :heavy_check_mark: (Sury) |
-| Ubuntu Xenial (16.04) | :heavy_check_mark:  | :x:                        | :x:                        | :x:                       | :x:                       |
-| Ubuntu Bionic (18.04) | :x:                 | :x:                        | :heavy_check_mark:         | :x:                       | :x:                       |
-| FreeBSD 11            | :heavy_check_mark:  | :heavy_check_mark:         | :heavy_check_mark:         | :heavy_check_mark:        | Need tests...             |
-| FreeBSD 12            | :heavy_check_mark:  | :heavy_check_mark:         | :heavy_check_mark:         | :heavy_check_mark:        | Need tests...             |
+On all Debian versions, you can install all PHP versions by using [Sury's APT repository](https://deb.sury.org/).
+
+Other cases:
+
+|         OS            |       PHP 7.0       |        PHP 7.1       |      PHP 7.2         |       PHP 7.3        |     PHP >= 7.4      |
+|:---------------------:|:-------------------:|:--------------------:|:--------------------:|:--------------------:|:--------------------:
+| Ubuntu Bionic (18.04) | :x:                 | :x:                  | :heavy_check_mark:   | :x:                  | :x:                 |
+| FreeBSD 11            | :heavy_check_mark:  | :heavy_check_mark:   | :heavy_check_mark:   | :heavy_check_mark:   | Need tests...       |
+| FreeBSD 12            | :heavy_check_mark:  | :heavy_check_mark:   | :heavy_check_mark:   | :heavy_check_mark:   | Need tests...       |

 Links:
 - [Sury](https://deb.sury.org/)
@@ -23,7 +24,9 @@ Links:
 Requirements
 ------------

-If you need PHP-FPM, you must install a webserver with FastCGI support. You can use my [nginx role](https://github.com/HanXHX/ansible-nginx).
+- Ansible >= 2.11
+- Collections: [community.general](https://galaxy.ansible.com/community/general)
+- If you need PHP-FPM, you must install a webserver with FastCGI support. You can use my [nginx role](https://github.com/HanXHX/ansible-nginx).

 FreeBSD limitations
 -------------------
@@ -158,14 +161,14 @@ Example Playbook

    - hosts: servers
      roles:
-         - { role: HanXHX.php }
+         - { role: hanxhx.php }

-### Debian Stretch with PHP 7.2 CLI (no FPM)
+### Debian Bullseye with PHP 8.0 CLI (no FPM)

    - hosts: servers
      roles:
         - { role: HanXHX.sury }
-         - { role: HanXHX.php, php_version: '7.2', php_install_fpm: false }
+         - { role: hanxhx.php, php_version: '8.0', php_install_fpm: false }

 License
 -------
--- a/32
+++ b/32
@@ -6,15 +6,11 @@
 Vagrant.configure("2") do |config|

  vms_debian = [
-    { :name => "debian-stretch-php70", :box => "debian/stretch64", :vars => { }},
-    { :name => "debian-stretch-php71", :box => "debian/stretch64", :vars => { "php_version": '7.1' }},
-    { :name => "debian-stretch-php72", :box => "debian/stretch64", :vars => { "php_version": '7.2' }},
-    { :name => "debian-stretch-php73", :box => "debian/stretch64", :vars => { "php_version": '7.3' }},
-    { :name => "debian-stretch-php74", :box => "debian/stretch64", :vars => { "php_version": '7.4' }},
-    { :name => "debian-buster-php73",  :box => "debian/buster64",  :vars => { }},
-    { :name => "debian-buster-php74",  :box => "debian/buster64",  :vars => { "php_version": '7.4' }},
-    { :name => "ubuntu-xenial-php70",  :box => "ubuntu/xenial64",  :vars => { }},
-    { :name => "ubuntu-bionic-php72",  :box => "ubuntu/bionic64",  :vars => { }},
+    { :name => "debian-buster-php73",   :box => "debian/buster64",   :vars => { }},
+    { :name => "debian-buster-php74",   :box => "debian/buster64",   :vars => { "php_version": '7.4' }},
+    { :name => "debian-bullseye-php74", :box => "debian/bullseye64", :vars => { }},
+    { :name => "debian-bullseye-php80", :box => "debian/bullseye64", :vars => { "php_version": '8.0' }},
+    { :name => "ubuntu-bionic-php72",   :box => "ubuntu/bionic64",   :vars => { }},
  ]

  vms_freebsd = [
@@ -23,15 +19,11 @@ Vagrant.configure("2") do |config|
  ]

  conts = [
-    { :name => "docker-debian-stretch-php70", :docker => "hanxhx/vagrant-ansible:debian9",     :vars => { }},
-    { :name => "docker-debian-stretch-php71", :docker => "hanxhx/vagrant-ansible:debian9",     :vars => { "php_version": '7.1' }},
-    { :name => "docker-debian-stretch-php72", :docker => "hanxhx/vagrant-ansible:debian9",     :vars => { "php_version": '7.2' }},
-    { :name => "docker-debian-stretch-php73", :docker => "hanxhx/vagrant-ansible:debian9",     :vars => { "php_version": '7.3' }},
-    { :name => "docker-debian-stretch-php74", :docker => "hanxhx/vagrant-ansible:debian9",     :vars => { "php_version": '7.4' }},
-    { :name => "docker-debian-buster-php73",  :docker => "hanxhx/vagrant-ansible:debian10",    :vars => { }},
-    { :name => "docker-debian-buster-php74",  :docker => "hanxhx/vagrant-ansible:debian10",    :vars => { "php_version": '7.4' }},
-    { :name => "docker-ubuntu-xenial-php70",  :docker => "hanxhx/vagrant-ansible:ubuntu16.04", :vars => { }},
-    { :name => "docker-ubuntu-bionic-php72",  :docker => "hanxhx/vagrant-ansible:ubuntu18.04", :vars => { }},
+    { :name => "docker-debian-buster-php73",   :docker => "hanxhx/vagrant-ansible:debian10",    :vars => { }},
+    { :name => "docker-debian-buster-php74",   :docker => "hanxhx/vagrant-ansible:debian10",    :vars => { "php_version": '7.4' }},
+    { :name => "docker-debian-bullseye-php74", :docker => "hanxhx/vagrant-ansible:debian11",    :vars => { }},
+    { :name => "docker-debian-bullseye-php80", :docker => "hanxhx/vagrant-ansible:debian11",    :vars => { "php_version": '8.0' }},
+    { :name => "docker-ubuntu-bionic-php72",   :docker => "hanxhx/vagrant-ansible:ubuntu18.04", :vars => { }},
  ]

  config.vm.network "private_network", type: "dhcp"
@@ -43,7 +35,8 @@ Vagrant.configure("2") do |config|
        d.remains_running = true
        d.has_ssh = true
      end
-      m.vm.provision "shell", inline: "apt-get update && apt-get install -y python python-apt"
+
+      #m.vm.provision "shell", inline: "apt-get update && apt-get install -y python python-apt"
      m.vm.provision "ansible" do |ansible|
        ansible.playbook = "tests/test.yml"
        ansible.verbose = 'vv'
@@ -61,6 +54,7 @@ Vagrant.configure("2") do |config|
        v.memory = 256
      end
      m.vm.provision "shell", inline: "apt-get update && apt-get install -y ifupdown python"
+
      m.vm.provision "ansible" do |ansible|
        ansible.playbook = "tests/test.yml"
        ansible.verbose = 'vv'
--- a/handlers/main.yml
+++ b/handlers/main.yml
@@ -1,14 +1,14 @@
 ---

- name: restart php-fpm
-  service:
+- name: Restart php-fpm
+  ansible.builtin.service:
    name: '{{ php_fpm_service }}'
    state: restarted
  when: php_install_fpm
-  notify: docker restart php-fpm
+  notify: Docker restart php-fpm

- name: docker restart php-fpm
-  command: 'service {{ php_fpm_service }} restart'
+- name: Docker restart php-fpm
+  ansible.builtin.command: 'service {{ php_fpm_service }} restart'
  args:
    warn: false
  when: ansible_virtualization_type == 'docker'
--- a/meta/argument_specs.yml
+++ b/meta/argument_specs.yml
@@ -0,0 +1,6 @@
+---
+
+argument_specs:
+  main:
+    short_description: Main entry point
+    options: {}
--- a/meta/main.yml
+++ b/meta/main.yml
@@ -1,32 +1,34 @@
 ---
 galaxy_info:
  author: Emilien Mantel
-  description: Install and configure PHP 7.0/7.1/7.2/7.3
-  company:
+  role_name: php
+  namespace: hanxhx
+  description: Install and configure PHP 7.x/8.x
+  company: TripleStack
  license: GPLv2
-  min_ansible_version: 2.6
+  min_ansible_version: '2.11'
  platforms:
-  - name: Debian
-    versions:
-    - stretch
-    - buster
-  - name: Ubuntu
-    versions:
-    - xenial
-    - bionic
-  - name: FreeBSD
-    versions:
-    - 11.0
-    - 11.1
-    - 12.0
+    - name: Debian
+      versions:
+        - buster
+        - bullseye
+    - name: Ubuntu
+      versions:
+        - bionic
+    - name: FreeBSD
+      versions:
+        - '11.0'
+        - '11.1'
+        - '12.0'
  galaxy_tags:
-  - development
-  - web
-  - php
-  - php-fpm
-  - php7
-  - debian
-  - ubuntu
-  - freebsd
-dependencies: []
+    - development
+    - web
+    - php
+    - fpm
+    - php7
+    - php8
+    - debian
+    - ubuntu
+    - freebsd

+dependencies: []
--- a/tasks/fpm.yml
+++ b/tasks/fpm.yml
@@ -1,36 +1,42 @@
 ---

 - name: APT | Install PHP-FPM for Debian based systems
-  apt:
+  ansible.builtin.apt:
    pkg: "{{ php_fpm_service }}"
    state: "{{ 'present' if php_install_fpm else 'absent' }}"
  when: ansible_os_family == 'Debian'

 - name: SERVICE | Enable service on FreeBSD
-  service:
+  ansible.builtin.service:
    name: "{{ php_fpm_service }}"
-    enabled: "{{ 'yes' if php_install_fpm else 'no' }}"
+    enabled: "{{ 'true' if php_install_fpm else 'false' }}"
  when: ansible_os_family == 'FreeBSD'

 - name: LINEINFILE | PHP configuration
-  lineinfile:
+  ansible.builtin.lineinfile:
    dest: '{{ php_fpm_ini }}'
    regexp: '^;?{{ item.key }}'
    line: '{{ item.key }} = {{ item.value }}'
-    create: yes
+    create: true
+    owner: root
+    group: root
+    mode: 0644
  loop: "{{ php_ini | combine(php_ini_fpm) | dict2items }}"
-  notify: restart php-fpm
+  notify: Restart php-fpm

 - name: TEMPLATE | Deploy pool configuration
-  template:
+  ansible.builtin.template:
    src: etc/__php__/fpm/pool.d/pool.conf.j2
    dest: '{{ php_fpm_pool_dir }}/{{ item.name }}.conf'
+    owner: root
+    group: root
+    mode: 0644
  loop: "{{ ansible_local.hanxhx_php.fpm_pool }}"
-  notify: restart php-fpm
+  notify: Restart php-fpm

 - name: FILE | Delete default pool if necessary
-  file:
+  ansible.builtin.file:
    path: "{{ php_fpm_pool_dir }}/www.conf"
    state: absent
  when: '"www" not in (ansible_local.hanxhx_php.fpm_pool | map(attribute="name") | list) and php_autoremove_default_pool'
-  notify: restart php-fpm
+  notify: Restart php-fpm
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -1,17 +1,26 @@
 ---

+- name: SHELL | Check if we are in multiple PHP distribution
+  ansible.builtin.shell: set -o pipefail && apt-cache search php xdebug | grep 'php[[:digit:]].[[:digit:]]'
+  args:
+    executable: /bin/bash
+  failed_when: false
+  changed_when: false
+  register: multiple_php
+  when: ansible_os_family == 'Debian'
+
 - name: INCLUDE_VARS | Related to OS family
-  include_vars: "OS_Family_{{ ansible_os_family }}.yml"
+  ansible.builtin.include_vars: "OS_Family_{{ ansible_os_family }}.yml"

 - name: INCLUDE_VARS | Related to OS version
-  include_vars: "{{ item }}"
+  ansible.builtin.include_vars: "{{ item }}"
  with_first_found:
    - "{{ ansible_distribution }}-{{ ansible_distribution_release }}.yml"
    - "{{ ansible_distribution }}-{{ ansible_distribution_version }}.yml"
    - "{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml"

 - name: SET_FACT | Transform data
-  set_fact:
+  ansible.builtin.set_fact:
    __php_fpm_full_pool: |
      [
      {% for p in php_fpm_poold %}
@@ -32,80 +41,88 @@
      ]

 - name: SET_FACT | To YAML
-  set_fact:
+  ansible.builtin.set_fact:
    php_fpm_full_pool: "{{ __php_fpm_full_pool | from_yaml }}"

 - name: FILE | Creates ansible facts.d
-  file:
+  ansible.builtin.file:
    path: /etc/ansible/facts.d
    state: directory
-    recurse: yes
+    owner: root
+    group: root
+    mode: 0755

 - name: COPY | Manage facts
-  copy:
+  ansible.builtin.copy:
    content: "{ \"fpm_pool\": {{ php_fpm_full_pool | to_nice_json }} }"
    dest: /etc/ansible/facts.d/hanxhx_php.fact
+    owner: root
+    group: root
+    mode: 0644
  register: f
+  tags:
+    - skip_ansible_lint

 - name: SETUP | Gathers new facts
-  setup:
+  ansible.builtin.setup:
  when: f.changed
  tags:
    - skip_ansible_lint

 - name: APT | Install PHP packages
-  apt:
+  ansible.builtin.apt:
    pkg: "{{ pkgs }}"
    state: present
-    update_cache: yes
+    update_cache: true
    cache_valid_time: 3600
+    install_recommends: false
  vars:
    pkgs: "{{ php_packages + php_extra_packages | flatten }}"
-  notify: restart php-fpm
+  notify: Restart php-fpm
  when: ansible_os_family == 'Debian'

 - name: PKGNG | Install PHP packages
-  pkgng:
+  community.general.pkgng:
    name: "{{ php_packages + php_extra_packages | flatten | join(',') }}"
-  notify: restart php-fpm
+  notify: Restart php-fpm
  when: ansible_os_family == 'FreeBSD'

 - name: IMPORT_TASKS | PHP-FPM
-  import_tasks: fpm.yml
+  ansible.builtin.import_tasks: fpm.yml

 - name: LINEINFILE | PHP CLI configuration
-  lineinfile:
+  ansible.builtin.lineinfile:
    dest: '{{ php_cli_ini }}'
    regexp: '^;?{{ item.key }}'
    line: '{{ item.key }} = {{ item.value }}'
  loop: "{{ php_ini | combine(php_ini_cli) | dict2items }}"

 - name: IMPORT_TASKS | Xdebug
-  import_tasks: xdebug.yml
+  ansible.builtin.import_tasks: xdebug.yml

 - name: APT | Install and configure opcache
-  import_tasks: opcache.yml
+  ansible.builtin.import_tasks: opcache.yml

 - name: SERVICE | Ensure PHP-FPM is started
-  service:
+  ansible.builtin.service:
    name: '{{ php_fpm_service }}'
    state: started
  when: php_install_fpm and ansible_virtualization_type != 'docker'

- block:
-
-  - name: COMMAND | Check if PHP-FPM is started (Docker)
-    command: 'service {{ php_fpm_service }} status'
-    args:
-      warn: false
-    register: dps
-    changed_when: false
-    failed_when: false
-
-  - name: COMMAND | Ensure PHP-FPM is started (Docker)
-    command: 'service {{ php_fpm_service }} start'
-    args:
-      warn: false
-    when: dps.stdout.find('is not running') != -1
-
+- name: BLOCK | Ensure PHP-FPM is started if running on Docker
  when: php_install_fpm and ansible_virtualization_type == 'docker'
+  block:
+
+    - name: COMMAND | Check if PHP-FPM is started (Docker)
+      ansible.builtin.command: 'service {{ php_fpm_service }} status'
+      args:
+        warn: false
+      register: dps
+      changed_when: false
+      failed_when: false
+
+    - name: COMMAND | Ensure PHP-FPM is started (Docker)
+      ansible.builtin.command: 'service {{ php_fpm_service }} start'
+      args:
+        warn: false
+      when: dps.stdout.find('is not running') != -1
--- a/tasks/opcache.yml
+++ b/tasks/opcache.yml
@@ -1,37 +1,46 @@
 ---

- block:
-
-  - name: APT | Install APCu
-    apt:
-      pkg: "php-apcu"
-
-  - name: APT | Install Opcache
-    apt:
-      pkg: "{{ php_package_prefix }}opcache"
-
+- name: Install opcache/apcu on Debian
  when: ansible_os_family == 'Debian'
+  block:

- block:
+    - name: APT | Install APCu
+      ansible.builtin.apt:
+        pkg: "{{ php_apcu_package }}"
+        install_recommends: false

-  - name: PKGNG | Install APCu
-    pkgng:
-      name: "php{{ php_version | replace('.', '') }}-pecl-APCu"
+    - name: APT | Install Opcache
+      ansible.builtin.apt:
+        pkg: "{{ php_package_prefix }}opcache"
+        install_recommends: false

-  - name: PKGNG | Install Opcache
-    pkgng:
-      name: "{{ php_package_prefix }}opcache"

+- name: Install opcache/apcu on FreeBSD
  when: ansible_os_family == 'FreeBSD'
+  block:
+
+    - name: PKGNG | Install APCu
+      community.general.pkgng:
+        name: "php{{ php_version | replace('.', '') }}-pecl-APCu"
+
+    - name: PKGNG | Install Opcache
+      community.general.pkgng:
+        name: "{{ php_package_prefix }}opcache"

 - name: TEMPLATE | Configure Opcache
-  template:
+  ansible.builtin.template:
    src: "etc/__php__/mods-available/opcache.ini.j2"
    dest: "{{ php_mods_dir }}/opcache.ini"
-  notify: restart php-fpm
+    owner: root
+    group: root
+    mode: 0644
+  notify: Restart php-fpm

 - name: TEMPLATE | Configure APCu
-  template:
+  ansible.builtin.template:
    src: "etc/__php__/mods-available/apcu.ini.j2"
    dest: "{{ php_mods_dir }}/apcu.ini"
-  notify: restart php-fpm
+    owner: root
+    group: root
+    mode: 0644
+  notify: Restart php-fpm
--- a/tasks/xdebug.yml
+++ b/tasks/xdebug.yml
@@ -1,42 +1,44 @@
 ---

- block:
-
-  - name: APT | Install xdebug
-    apt:
-      pkg: "{{ php_xdebug_package }}"
-      state: present
-      update_cache: yes
-      cache_valid_time: 3600
-    when: ansible_os_family == 'Debian'
-
-  - name: PKGNG | Install xdebug
-    pkgng:
-      name: "{{ php_xdebug_package }}"
-    when: ansible_os_family == 'FreeBSD' and php_xdebug_package is defined
-
-  - name: TEMPLATE | Deploy module configurations
-    template:
-      src: "etc/__php__/mods-available/xdebug.ini.j2"
-      dest: "{{ php_mods_dir }}/xdebug.ini"
-      owner: root
-      mode: 0644
-    notify: restart php-fpm
-
+- name: BLOCK | Uninstall xdebug
  when: php_install_xdebug
+  block:

- block:
+    - name: APT | Install xdebug
+      ansible.builtin.apt:
+        pkg: "{{ php_xdebug_package }}"
+        state: present
+        update_cache: true
+        cache_valid_time: 3600
+        install_recommends: false
+      when: ansible_os_family == 'Debian'

-  - name: APT | Uninstall xdebug
-    apt:
-      pkg: "{{ php_xdebug_package }}"
-      state: absent
-    when: ansible_os_family == 'Debian'
+    - name: PKGNG | Install xdebug
+      community.general.pkgng:
+        name: "{{ php_xdebug_package }}"
+      when: ansible_os_family == 'FreeBSD' and php_xdebug_package is defined

-  - name: PKGNG | Uninstall xdebug
-    pkgng:
-      name: "{{ php_xdebug_package }}"
-      state: absent
-    when: ansible_os_family == 'FreeBSD'
+    - name: TEMPLATE | Deploy module configurations
+      ansible.builtin.template:
+        src: "etc/__php__/mods-available/xdebug.ini.j2"
+        dest: "{{ php_mods_dir }}/xdebug.ini"
+        owner: root
+        mode: 0644
+      notify: Restart php-fpm

+
+- name: BLOCK | Uninstall xdebug
  when: not php_install_xdebug
+  block:
+
+    - name: APT | Uninstall xdebug
+      ansible.builtin.apt:
+        pkg: "{{ php_xdebug_package }}"
+        state: absent
+      when: ansible_os_family == 'Debian'
+
+    - name: PKGNG | Uninstall xdebug
+      community.general.pkgng:
+        name: "{{ php_xdebug_package }}"
+        state: absent
+      when: ansible_os_family == 'FreeBSD'
--- a/tests/includes/Debian/sury.yml
+++ b/tests/includes/Debian/sury.yml
@@ -1,9 +1,9 @@
 ---

 - name: APT | Install Sury key
-  apt_key:
+  ansible.builtin.apt_key:
    url: 'https://packages.sury.org/php/apt.gpg'

 - name: APT_REPOSITORY | Add Sury repository
-  apt_repository:
+  ansible.builtin.apt_repository:
    repo: 'deb https://packages.sury.org/php/ {{ ansible_distribution_release }} main'
--- a/tests/includes/pre_Debian.yml
+++ b/tests/includes/pre_Debian.yml
@@ -1,25 +1,24 @@
 ---

 - name: SET_FACT | Prepare test vars
-  set_fact:
+  ansible.builtin.set_fact:
    __nginx_conf: /etc/nginx/nginx.conf

 - name: APT | Install packages
-  apt:
+  ansible.builtin.apt:
    pkg: "{{ p }}"
-    update_cache: yes
+    update_cache: true
    cache_valid_time: 3600
  vars:
    p:
      - apt-transport-https
      - ca-certificates
      - curl
+      - gpg
      - lsb-release
      - nginx
      - vim

 - name: INCLUDE_TASKS | Sury
-  include_tasks: Debian/sury.yml
-  when:
-    ((ansible_distribution_major_version is version('9', 'eq')) and (php_version is version('7.1', 'ge'))) or
-    ((ansible_distribution_major_version is version('10', 'eq')) and (php_version is version('7.4', 'ge')))
+  ansible.builtin.include_tasks: Debian/sury.yml
+  when: php_version != php_default_version
--- a/tests/includes/pre_FreeBSD.yml
+++ b/tests/includes/pre_FreeBSD.yml
@@ -1,10 +1,10 @@
 ---

 - name: SET_FACT | Prepare test vars
-  set_fact:
+  ansible.builtin.set_fact:
    __nginx_conf: /usr/local/etc/nginx/nginx.conf
    php_xdebug_package: 'php72-pecl-xdebug-2.6.1'

 - name: PKGNG | Install packages
-  pkgng:
+  community.general.pkgng:
    name: ['curl', 'nginx']
--- a/tests/test.yml
+++ b/tests/test.yml
@@ -1,6 +1,7 @@
 ---

 - hosts: all
+  name: Test all
  vars:
    vhost: 'test.local'
    php_extra_packages:
@@ -32,73 +33,76 @@
  pre_tasks:

    - name: INCLUDE_TASKS | Pre tasks related to OS
-      include_tasks: "includes/pre_{{ ansible_os_family }}.yml"
+      ansible.builtin.include_tasks: "includes/pre_{{ ansible_os_family }}.yml"

    - name: USER | Create PHP user
-      user:
+      ansible.builtin.user:
        name: 'foo'
-        system: yes
-        create_home: no
+        system: true
+        create_home: false
        shell: '/usr/sbin/nologin'

  tasks:

    - name: TEMPLATE | Nginx site config
-      template:
+      ansible.builtin.template:
        src: "templates/nginx.conf.j2"
-        dest: "{{ __nginx_conf  }}"
-      notify: reload nginx
+        dest: "{{ __nginx_conf }}"
+        mode: 0644
+        owner: root
+        group: root
+      notify: Reload nginx

    - name: COMMAND | Fix nginx config
-      command: "cp {{ __nginx_conf | dirname }}/fastcgi_params {{ __nginx_conf | dirname }}/fastcgi.conf"
+      ansible.builtin.command: "cp {{ __nginx_conf | dirname }}/fastcgi_params {{ __nginx_conf | dirname }}/fastcgi.conf"
      args:
        creates: "{{ __nginx_conf | dirname }}/fastcgi.conf"
-      notify: reload nginx
+      notify: Reload nginx

    - name: LINEINFILE | Fix nginx config (second step)
-      lineinfile:
+      ansible.builtin.lineinfile:
        regexp: '^fastcgi_param\s+SCRIPT_FILENAME'
        line: "fastcgi_param  SCRIPT_FILENAME    $realpath_root$fastcgi_script_name;"
        dest: "{{ __nginx_conf | dirname }}/fastcgi.conf"
-      notify: reload nginx
+      notify: Reload nginx

    - name: SERVICE | Ensure nginx is started
-      service:
+      ansible.builtin.service:
        name: nginx
        state: started
      when: ansible_virtualization_type != 'docker'

-    - block:
-
-      - name: COMMAND | Docker nginx status
-        command: service nginx status
-        args:
-          warn: false
-        changed_when: false
-        failed_when: false
-        register: ngs
-
-      - name: COMMAND | Docker start nginx
-        command: service nginx start
-        args:
-          warn: false
-        when: ngs.stdout.find('nginx is not running') != -1
-
+    - name: Start nginx if testing with Docker
      when: ansible_virtualization_type == 'docker'
+      block:
+
+        - name: COMMAND | Docker nginx status
+          ansible.builtin.command: service nginx status
+          args:
+            warn: false
+          changed_when: false
+          failed_when: false
+          register: ngs
+
+        - name: COMMAND | Docker start nginx
+          ansible.builtin.command: service nginx start
+          args:
+            warn: false
+          when: ngs.stdout.find('nginx is not running') != -1

  handlers:

-    - name: reload nginx
-      service:
+    - name: Reload nginx
+      ansible.builtin.service:
        name: nginx
        state: reloaded
-      notify: docker reload nginx
+      notify: Docker reload nginx

-    - name: docker reload nginx
-      command: service nginx reload
+    - name: Docker reload nginx
+      ansible.builtin.command: service nginx reload
      args:
        warn: false
-      notify: docker reload nginx
+      notify: Docker reload nginx
      when: ansible_virtualization_type == 'docker'

  roles:
@@ -107,36 +111,48 @@
  post_tasks:

    - name: SHELL | Test php-cli
-      shell: php -i | grep '^PHP Version => {{ php_version }}' | head -n 1
+      ansible.builtin.shell: set -o pipefail && php -i | grep '^PHP Version => {{ php_version }}' | head -n 1
      changed_when: false
      register: p
      failed_when: p.stdout == ''
+      args:
+        executable: /bin/bash

    - name: FILE | Create /var/www
-      file:
+      ansible.builtin.file:
        dest: /var/www
        state: directory
+        owner: root
+        group: root
+        mode: 0755

    - name: COPY | Add phpinfo
-      copy:
+      ansible.builtin.copy:
        dest: /var/www/phpinfo.php
        content: '<?php phpinfo();'
+        owner: root
+        group: root
+        mode: 0644

    - name: COPY | Add ini test file
-      copy:
+      ansible.builtin.copy:
        dest: /var/www/ini.php
        content: '<?php echo ini_get("memory_limit") . "\n";'
+        owner: root
+        group: root
+        mode: 0644

    - name: SHELL | Check vhost
-      shell: "curl -v -H 'Host: {{ vhost }}' http://127.0.0.1/phpinfo.php 2> /dev/null | grep h1 | grep -o 'PHP Version {{ php_version }}' | sed -r 's/<//g'"
+      ansible.builtin.shell: "set -o pipefail && curl -v -H 'Host: {{ vhost }}' http://127.0.0.1/phpinfo.php 2> /dev/null | grep h1 | grep -o 'PHP Version {{ php_version }}' | sed -r 's/<//g'"
      args:
        warn: false
+        executable: /bin/bash
      changed_when: false
      register: c
      failed_when: c.stdout == ''

    - name: SHELL | Check custom php value
-      shell: "curl -H 'Host: {{ vhost }}' http://127.0.0.1/ini.php 2> /dev/null"
+      ansible.builtin.shell: "curl -H 'Host: {{ vhost }}' http://127.0.0.1/ini.php 2> /dev/null"
      args:
        warn: false
      changed_when: false
@@ -144,11 +160,29 @@
      failed_when: 'php_fpm_poold.1.php_admin_value.memory_limit not in c.stdout'

    - name: URI | Check ping
-      uri:
+      ansible.builtin.uri:
        url: "http://localhost{{ php_fpm_poold.0.ping_path }}"
      when: php_fpm_poold.0.ping_path is defined

    - name: URI | Check status
-      uri:
+      ansible.builtin.uri:
        url: "http://localhost{{ php_fpm_poold.0.status_path }}"
      when: php_fpm_poold.0.status_path is defined
+
+    - name: Debian extra checks
+      when: ansible_os_family == 'Debian'
+      block:
+
+        - name: SHELL | Check if we installed multiple PHP versions
+          ansible.builtin.shell: set -o pipefail && (dpkg -l | grep 'php[[:digit:]].*common' | wc -l)
+          args:
+            executable: /bin/bash
+          failed_when: false
+          changed_when: false
+          register: check_multiple_php
+
+
+        - name: FAIL | If we have multiple PHP version
+          ansible.builtin.fail:
+            msg: "Multiple PHP versions detected"
+          when: check_multiple_php.stdout != '1'
--- a/vars/Debian-bullseye.yml
+++ b/vars/Debian-bullseye.yml
@@ -0,0 +1,3 @@
+---
+
+php_default_version: '7.4'
--- a/vars/Debian-buster.yml
+++ b/vars/Debian-buster.yml
@@ -1 +1,3 @@
+---
+
 php_default_version: '7.3'
--- a/vars/Debian-stretch.yml
+++ b/vars/Debian-stretch.yml
@@ -1 +0,0 @@
-php_default_version: '7.0'
--- a/vars/FreeBSD-11.yml
+++ b/vars/FreeBSD-11.yml
@@ -1 +1,3 @@
+---
+
 php_default_version: '7.2'
--- a/vars/FreeBSD-12.yml
+++ b/vars/FreeBSD-12.yml
@@ -1 +1,3 @@
+---
+
 php_default_version: '7.2'
--- a/vars/OS_Family_Debian.yml
+++ b/vars/OS_Family_Debian.yml
@@ -7,7 +7,8 @@ php_packages:
  - '{{ php_package_prefix }}mysql'
  - '{{ php_package_prefix }}intl'

-php_xdebug_package: 'php-xdebug'
+php_xdebug_package: '{% if multiple_php.rc == 0 %}{{ php_package_prefix }}{% else %}php-{% endif %}xdebug'
+php_apcu_package: '{% if multiple_php.rc == 0 %}{{ php_package_prefix }}{% else %}php-{% endif %}apcu'

 php_package_prefix: 'php{{ php_version }}-'

--- a/vars/Ubuntu-bionic.yml
+++ b/vars/Ubuntu-bionic.yml
@@ -1 +1,3 @@
+---
+
 php_default_version: '7.2'
--- a/vars/Ubuntu-xenial.yml
+++ b/vars/Ubuntu-xenial.yml
@@ -1 +1,3 @@
+---
+
 php_default_version: '7.0'
Author	SHA1	Message	Date
Emilien Mantel	afbb2c7c6f	Drop debian stretch support	2022-10-06 14:38:21 +02:00
Emilien Mantel	701697984e	Fix some handlers	2022-10-06 14:28:40 +02:00
Emilien Mantel	fc04f1e15a	Fix again...	2022-10-06 12:52:19 +02:00
Emilien Mantel	49d32908b8	Fixt others lint errors	2022-10-06 12:42:56 +02:00
Emilien Mantel	85cab7d166	Fix lint errors due to ansible-lint latest versions	2022-10-06 12:14:55 +02:00
Emilien Mantel	4aef107c1a	🐛 Fix multiple PHP versions install With Sury packages...	2022-02-22 13:41:02 +01:00
Emilien Mantel	28caf6d9c9	⚡ Remove useless provision in Vagrant	2022-02-22 13:31:19 +01:00
Emilien M	309824dabf	New release (#14 ) * Manages Debian 11 * Migrate to new TravisCI version * Fix lint errors * Use FQCN builtins * Drop Ubuntu Xenial support (16.04)	2021-09-01 09:57:23 +02:00